Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure follow behavior works when streaming to paginated Tabulator #7084

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6800

panel/models/tabulator.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (663a159) to head (4865d2c).
Report is 1 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7084      +/-   ##
==========================================
- Coverage   82.23%   81.76%   -0.47%     
==========================================
  Files         326      326              
  Lines       48536    48548      +12     
==========================================
- Hits        39914    39696     -218     
- Misses       8622     8852     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 9af5509 into main Aug 7, 2024
15 checks passed
@philippjfr philippjfr deleted the tabulator-paginated_streaming branch August 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator with frozen_rows scrolling/paging to top when updating content
1 participant