Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid events boomeranging from frontend #7093

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Avoid events boomeranging from frontend #7093

merged 7 commits into from
Aug 7, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 7, 2024

This adds a long overdue change which ensures that events arriving from the frontend do not boomerang. There was a previous attempt at doing this but instead of skipping events being applied that originated on the frontend it cancelled the processing of new events after a property change was made. These approaches have potentially similar effects but in fact are quite different, since the old change effectively would potentially cause a property to revert to an older value.

Fixes #7096
Fixes #6738
Fixes #6414

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Aug 7, 2024

Will this solve issue with ChatInterface? I.e. the problem that if you don't type slowly then text will disappear?

chatinterface-text-disappearing.mp4

@philippjfr
Copy link
Member Author

Will this solve issue with ChatInterface? I.e. the problem that if you don't type slowly then text will disappear?

I have never encountered that problem, the problem it is meant to solve is that the chat feed scroll position isn't stable.

@MarcSkovMadsen
Copy link
Collaborator

I will make a separate issue then.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (1083ed2) to head (7e20bc8).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/reactive.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7093      +/-   ##
==========================================
- Coverage   82.22%   81.74%   -0.49%     
==========================================
  Files         326      326              
  Lines       48548    48586      +38     
==========================================
- Hits        39920    39717     -203     
- Misses       8628     8869     +241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

A reproducer would be very helpful. I definitely can't reproduce this with a bare chat interface.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Aug 7, 2024

Hmmm. The problem is only with the deployed app. When developing on jupyter hub with proxy server there is no problem. That is strange as it should be the same. But I also experience my deployed apps being slower even though they have the same resources available.

I've had the problem "for ever". Thought everyone was experiencing it.

@philippjfr
Copy link
Member Author

Yeah literally never seen it and we have many chat apps in production with different clients.

@philippjfr philippjfr merged commit 4c49251 into main Aug 7, 2024
16 checks passed
@philippjfr philippjfr deleted the boomerang_fix branch August 7, 2024 19:10
@duarteocarmo
Copy link

Hey @philippjfr any idea when this will be available? (I know 1.4.5, just wondering if there is a release date for that, or an option to release it sooner?)

Thanks!

@duarteocarmo
Copy link

We are observing the same issue as @MarcSkovMadsen in #7096

@philippjfr
Copy link
Member Author

I was planning to cut 1.5.0rc1 today and then make the proper release some time next week.

@duarteocarmo
Copy link

Awesome - appreciate it. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants