Hide typing constructs behind TYPE_CHECKING guard #7094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7094 +/- ##
==========================================
- Coverage 82.22% 82.22% -0.01%
==========================================
Files 326 326
Lines 48552 48554 +2
==========================================
- Hits 39924 39923 -1
- Misses 8628 8631 +3 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Aug 7, 2024
|
Much appreciated, thanks for following up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@philippjfr Clean up to adopt @hoxbro feedback on the other PR
I deliberately left
ProfilingEnginepublic as I didn't want to preclude the possibility of someone actually using this type themselves in their own code.