Correctly detect max depth of NestedSelect if level is empty #7194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7194 +/- ##
==========================================
- Coverage 82.23% 82.23% -0.01%
==========================================
Files 331 331
Lines 49359 49360 +1
==========================================
- Hits 40591 40589 -2
- Misses 8768 8771 +3 ☔ View full report in Codecov by Sentry. |
ahuang11
reviewed
Aug 29, 2024
| @@ -500,7 +509,7 @@ def test_nested_select_partial_options_set(document, comm): | |||
| select.options = {"Ben": []} | |||
| assert select._widgets[0].value == 'Ben' | |||
| assert select._widgets[0].visible | |||
| assert select.value == {0: 'Ben'} | |||
| assert select.value == {0: 'Ben', 1: None} | |||
There was a problem hiding this comment.
I'm wondering if this 1: None is correct?
There was a problem hiding this comment.
Seems correct to me, there are two levels after all, even if one of them is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty levels were not treated correctly, resulting in errors when a leaf was empty and incorrectly treating a two-level
NestedSelectas a single level