Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator selection consistency when pagination='local' #7304

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 20, 2024

When pagination was set to 'local', selections were not being computed correctly when header_filters were being applied. Specifically the problem was that the header_filters were still being applied on the server, which would cause the selection going out of sync with the data that was visible to the frontend. We fix this by not applying header_filters on the server in this scenario, and only when the user accesses the current_view do we apply the additional filters so that the view the user sees still matches what is visible on the frontend.

panel/models/tabulator.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.34146% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (8c6f2d5) to head (526eed0).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/conftest.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7304      +/-   ##
==========================================
+ Coverage   82.18%   82.20%   +0.01%     
==========================================
  Files         337      337              
  Lines       50393    50439      +46     
==========================================
+ Hits        41418    41463      +45     
- Misses       8975     8976       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit fbb540d into main Sep 23, 2024
16 checks passed
@philippjfr philippjfr deleted the tabulator_selection_local branch September 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant