Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator redraw is called after full render #7305

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 20, 2024

There were some major issues with the logic responsible for ensuring that the Tabulator was redrawn. In fact the logic was specifically skipping redraws if this.tabulator != null, so we never triggered the redraw at all since this completely incorrect PR 3 months ago: #6930

Some additional improvements we make here:

  • Do not trigger a redraw, while another is in process (this could happen because a redraw can trigger a resize which triggers another redraw)
  • We do not trigger a initial redraw until the root.has_finished (i.e. the page is fully rendered).

@philippjfr philippjfr added this to the v1.5.1 milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (1e8827b) to head (68ecf58).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7305      +/-   ##
==========================================
- Coverage   82.19%   82.18%   -0.01%     
==========================================
  Files         337      337              
  Lines       50380    50394      +14     
==========================================
+ Hits        41411    41418       +7     
- Misses       8969     8976       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 32b147d into main Sep 20, 2024
16 checks passed
@philippjfr philippjfr deleted the tabulator_redraw_consistency branch September 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant