Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ChatMessage margins #7310

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Tweak ChatMessage margins #7310

merged 1 commit into from
Sep 24, 2024

Conversation

ahuang11
Copy link
Contributor

Without the divider, the reaction icons were too far left.
image

Then I noticed that the chat copy icon and reaction icons were misaligned vertically.
image

I also noticed that the chat copy icon and reaction icons inline spacing were somewhat different (more space between each reaction icon vs reaction icons + chat copy icon)
image

So I tweaked it all:

Before:
image

After:
image

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (d4f7d68) to head (aede3ca).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7310   +/-   ##
=======================================
  Coverage   82.18%   82.19%           
=======================================
  Files         337      337           
  Lines       50380    50394   +14     
=======================================
+ Hits        41407    41422   +15     
+ Misses       8973     8972    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't think making single pixel adjustments is the correct way to fix this, but for now it's an improvement and I'll merge.

@philippjfr philippjfr merged commit 252a85e into main Sep 24, 2024
16 checks passed
@philippjfr philippjfr deleted the tweak_chat_css branch September 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants