Skip to content

Conversation

@philippjfr
Copy link
Member

The patch_model_css function switches out the stylesheets depending on the resource mode but should not dispatch events unless the app is fully loaded, otherwise in can trigger the dreaded _pending_writes error. This ensures we only unhold if the page is loaded.

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (081b71a) to head (cdc3016).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7978       +/-   ##
===========================================
+ Coverage   71.22%   87.08%   +15.86%     
===========================================
  Files         345      346        +1     
  Lines       53373    53374        +1     
===========================================
+ Hits        38014    46480     +8466     
+ Misses      15359     6894     -8465     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit f9b1091 into main Jun 11, 2025
32 of 35 checks passed
@philippjfr philippjfr deleted the unhold_patch_css branch June 11, 2025 15:02
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants