Skip to content

Conversation

@philippjfr
Copy link
Member

bokeh serve CLI allows setting an --ico-path to control the favicon. Since we perform our own handling of favicons this option was ignored. We now hook into the mechanism.

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (0bb1ccc) to head (119ce21).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
panel/template/base.py 80.00% 2 Missing ⚠️
panel/command/serve.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7992      +/-   ##
==========================================
- Coverage   87.07%   86.04%   -1.04%     
==========================================
  Files         346      346              
  Lines       53374    53460      +86     
==========================================
- Hits        46478    45997     -481     
- Misses       6896     7463     +567     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit 11420c0 into main Jun 19, 2025
15 of 18 checks passed
@philippjfr philippjfr deleted the ico_path branch June 19, 2025 16:54
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants