Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

param namespace fixups #235

Merged
merged 4 commits into from
Jun 25, 2018
Merged

param namespace fixups #235

merged 4 commits into from
Jun 25, 2018

Conversation

ceball
Copy link
Contributor

@ceball ceball commented Jun 25, 2018

  • Restores _set_name() to Parameterized (still deprecated).
  • Restores state_push() and state_pop() to Parameterized - and don't deprecate - because subclasses may be overriding.

If we want to change/remove Parameters._set_name() and/or Parameterized.state_push/pop(), that should be discussed separately (e.g. #233).

@ceball ceball requested a review from jlstevens June 25, 2018 15:06
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 70.36% when pulling 6734655 on param_namespace_fixups into 154edba on param_namespace.

@jlstevens
Copy link
Contributor

Looks good to me. Ready to merge?

@ceball
Copy link
Contributor Author

ceball commented Jun 25, 2018

Yes, I'm finished

@jlstevens jlstevens merged commit b001dfe into param_namespace Jun 25, 2018
@philippjfr philippjfr deleted the param_namespace_fixups branch September 27, 2018 21:34
@jlstevens jlstevens removed their request for review July 5, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ceball @coveralls @jlstevens