Upgrade code base to Python 3 #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
Apr 17, 2023
param/ipython.py
Outdated
| @@ -168,7 +160,7 @@ def _build_table(self, info, order, max_col_len=40, only_changed=False): | |||
| readonly = 'RO' if p.readonly else 'RW' | |||
| allow_None = ' AN' if hasattr(p, 'allow_None') and p.allow_None else '' | |||
|
|
|||
| mode = '%s %s%s' % (constant, readonly, allow_None) | |||
| mode = '{} {}{}'.format(constant, readonly, allow_None) | |||
There was a problem hiding this comment.
Agreed. Should probably one of those tools that automatically update to f-strings over the codebase. Looks to me like pyupgrade used this style throughout...
|
Looks mostly like I would expect though I would definitely prefer f-strings everywhere. Currently it is removing all the |
|
Agreed, |
hoxbro
reviewed
Apr 21, 2023
|
I get some more string conversion if I use Ruff: |
|
I've applied the suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #703
I ran
pyupgradeon the code base to upgrade it to Python 3.7, and then manually made some other upgrades. Notable changes include:watchandon_initkeywords to the signature ofdependsparam.as_unicodeparam.is_ordered_dictEdit:
warnkeyword to the signature ofparam_union