Add tests for add_parameter
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_parameterhas been committed to this repo in 2012, and as far as I can see has been pretty much untested till now but also unchanged so it might just still work as well as it did 11 years ago. Since the private namespace PR is touching it I thought it'd be wise to add at least some basic tests, not to break it entirely.By the way the only usage I've been able to find is in Lumen:
https://github.com/holoviz/lumen/blob/6bb7bb79f79b0efc1f6fe67af1843df43ba0414f/lumen/variables/base.py#L147