Validate that 'self' is present in the init signature of a Parameterized class
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximlt
changed the title
'self' if present in the init signature of a Parameterized class'self' is present in the init signature of a Parameterized class
hoxbro
reviewed
Jul 4, 2023
There was a problem hiding this comment.
I would maybe make a subclass with a custom __init__ and use that as a base to not mess around with param.Parameterized directly.
Maybe also have an example with a parameter in it with a non-default (If it does not already exist.)
This still needs a change in Holoviews, correct?
|
I addressed your comments.
|
hoxbro
reviewed
Jul 10, 2023
hoxbro
approved these changes
Jul 10, 2023
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #785