Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSelector defaults to the first globbed path #801

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 27, 2023

Addresses the first issue raised #545, i.e. that the FileSelector parameter is not updating its default value to the first path found in objects, which is inconsistent with how Selector works.

@jlstevens
Copy link
Contributor

Looks good to me!

Right now it looks like the glob is run when the parameter is declared which is probably what I would expect. Unlike Selector, the set of 'objects' is implicit so I think it might be worth stating in the docstring that the glob is run at the point where the parameter is declared.

@maximlt
Copy link
Member Author

maximlt commented Jul 28, 2023

Thanks for the review! I'll update the docstring in another PR.

@maximlt maximlt merged commit 754dcfd into main Jul 28, 2023
@maximlt maximlt deleted the fileselector_default branch July 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants