Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install “doc” in site-packages (fix #877) #878

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

musicinmybrain
Copy link
Contributor

Tested in a clean git checkout:

python3 -m build
python3 -m wheel unpack dist/param-*.whl
find param-*/doc/
find: ‘param-*/doc/’: No such file or directory

@maximlt
Copy link
Member

maximlt commented Nov 6, 2023

Hi @musicinmybrain, thanks for spotting that, it's indeed pretty bad :/ I was surprised to see that though as in pyproject.toml the target folders were explicitly specified. Except that not quite like hatch expected it! Prefixing them with a slash fixed it, which is the real fix.

@maximlt maximlt merged commit e9b2781 into holoviz:main Nov 6, 2023
10 checks passed
@musicinmybrain
Copy link
Contributor Author

Hi @musicinmybrain, thanks for spotting that, it's indeed pretty bad :/

As a Linux distribution packager, I’ve seen it dozens of times, including in official projects from billion-dollar companies. Don’t feel bad! It’s easy to miss stray files in a virtualenv.

Prefixing them with a slash fixed it, which is the real fix.

I agree that this is a much better fix. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants