New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set `creationflags` on Windows only #886

Merged

maximlt merged 1 commit into main from set_flags_on_windows_only

Nov 8, 2023

Member

maximlt commented Nov 8, 2023

subprocess.CREATE_NO_WINDOW is a Windows constant so it fails on other platforms: https://docs.python.org/3/library/subprocess.html#windows-constants.

Also adding a simple test that would have caught that.


          set creationflags on Windows only

dbbaf45

maximlt merged commit 84c2852 into main

10 checks passed

maximlt deleted the set_flags_on_windows_only branch

November 8, 2023 12:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet