Renamed to pyviz_comms and added Python package #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
philippjfr
reviewed
May 21, 2018
conda.recipe/meta.yaml
Outdated
| - pyviz_comms | ||
|
|
||
| about: | ||
| home: www.holoviews.org |
There was a problem hiding this comment.
Addressed in 7e1ef97
philippjfr
reviewed
May 21, 2018
| PYVIZ_PROXY = """ | ||
| if (window.PyViz === undefined) { | ||
| if (window.HoloViews === undefined) { | ||
| var PyViz = {comms: {}, comm_status:{}, kernels:{}, receivers: {}, plot_index: []} |
There was a problem hiding this comment.
Consistent spacing would be nice if you're already making the change above.
|
If we are happy with the current setup.py, I'll register this on PyPI and then this PR can be merged. |
|
@philippjfr @jbednar Probably makes more sense to merge this and then register on PyPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the shared Python comms component used by pyviz projects. This complements the Jupyterlab extension which must be installed to allow comms to work in that environment.