Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set python-snappy as optional dependency #117

Merged
merged 1 commit into from
May 23, 2023
Merged

Set python-snappy as optional dependency #117

merged 1 commit into from
May 23, 2023

Conversation

weiji14
Copy link
Contributor

@weiji14 weiji14 commented May 22, 2023 •
edited
Loading

To make spatialpandas pip installable from PyPI on Python 3.11 without the python-snappy dependency.

Fixes #116

@weiji14 weiji14 mentioned this pull request May 22, 2023
Closed
@weiji14 weiji14 marked this pull request as ready for review May 23, 2023 03:25
ianthomas23
ianthomas23 approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weiji14, CI is passing so I'll merge as is.

There will be a new release of spatialpandas later in the week.

@ianthomas23 ianthomas23 merged commit 23c3a01 into holoviz:main May 23, 2023
@weiji14 weiji14 deleted the optional-snappy branch May 23, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set python-snappy as optional dependency to work with Python 3.11 on pip install
2 participants
@weiji14 @ianthomas23