Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension array fixes #88

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

ianthomas23
Copy link
Member

This PR fixes the errors related to ragged arrays being pandas extension arrays which have had extra tests added. The "fixes" are all to disable those tests as the functionality does not apply to our ragged arrays.

Also temporarily limited github actions to only run testing on Python 3.8 on Linux until I have dealt with all of the current errors.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Is there any way that pandas could make these tests opt-in, so this wouldn't keep happening?

@ianthomas23
Copy link
Member Author

I am not an expert on pandas extension arrays, but it looks like we are using them in the recommended way by defining test classes that inherit from the pandas extension array test classes and these naturally run all the tests defined in both classes. So we have to identify the tests we don't want to run and override them to be skipped. I can't see how pandas could be altered to work how we want it too.

One possible approach would be to implement some sort of filter on pytest's automatic finding of all tests so that we only run tests that are in some specified whitelist.

@ianthomas23
Copy link
Member Author

The pyarrow import errors are masking the fixes here, but locally this PR removes the extension array errors so I will merge and continue with the next set of errors.

@ianthomas23 ianthomas23 merged commit 748ed3f into holoviz:master Jun 22, 2022
@ianthomas23 ianthomas23 deleted the extension_array_fixes branch June 22, 2022 13:41
@jbednar
Copy link
Member

jbednar commented Jun 22, 2022

Seems like Pandas ExtensionArray tests could be broken into a minimal or at least static set of tests, with other tests or new tests implemented in a subclass, so that we could safely invoke the standard tests without having to guard against all new tests that might be added someday?

@ianthomas23
Copy link
Member Author

Yes, but wouldn't changes to Pandas itself require either persuading Pandas devs to do this for us, or one of us to volunteer to do the work ourselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants