Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use code formatter (plugins) to ensure formatting of src files #61

Open
jangalinski opened this issue Jul 22, 2020 · 1 comment · May be fixed by #281
Open

use code formatter (plugins) to ensure formatting of src files #61

jangalinski opened this issue Jul 22, 2020 · 1 comment · May be fixed by #281
Assignees
@mmiikkkkaa
Labels
Prio: Should This feature should be implemented. State: in progress Assignee is working on the issue. Type: enhancement New feature or request
Milestone
BACKLOG

Comments

@jangalinski
Copy link
Contributor

Scenario

on PR #60 , codacy com plains about asterisk imports in some java classes. Those happend due to ideas automatic formatting.

Wanted Behaviour

I want to ensure that my code formatting complies to projects standards without manually worrying about it.

Ideas

There is one well established code formatter for java: google-java-format. It provides IDE plugins and maven formatting tasks. We should use this.

However, it does not support kotlin ... that's where ktfmt might be of help. But it does not come with an IDEA plugin ... and I do not know how those two tools will play together ....
@jangalinski jangalinski assigned zambrovski and unassigned zambrovski Jul 22, 2020
@jangalinski jangalinski added the idea New idea introduced label Jul 22, 2020
@jangalinski jangalinski mentioned this issue Jul 26, 2020
Merged
4 tasks
@mmiikkkkaa
Copy link
Contributor

What about spotless? It supports kotlin out of the box.

https://github.com/diffplug/spotless

@mmiikkkkaa mmiikkkkaa linked a pull request Oct 14, 2022 that will close this issue
61 use code formatter plugins to ensure formatting of src files #281
Open
@zambrovski zambrovski added Type: enhancement New feature or request State: in progress Assignee is working on the issue. Prio: Should This feature should be implemented. and removed idea New idea introduced labels Nov 17, 2022
@zambrovski zambrovski added this to the 1.3.0 milestone Nov 17, 2022
@zambrovski zambrovski modified the milestones: 1.3.0, 1.4.0, BACKLOG Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmiikkkkaa mmiikkkkaa

Labels
Prio: Should This feature should be implemented. State: in progress Assignee is working on the issue. Type: enhancement New feature or request
Projects
None yet
Milestone
BACKLOG
Development

Successfully merging a pull request may close this issue.

61 use code formatter plugins to ensure formatting of src files holunda-io/camunda-bpm-data
3 participants
@zambrovski @jangalinski @mmiikkkkaa