Feature/59 case variables

[jangalinski]

Adds support for variable access on caseService.

see #59

• implement factories
• implement adapters
• finalize tests
• add documentation

[codecov]

Codecov Report

Merging #60 into develop will decrease coverage by 1.21%.
The diff coverage is 53.17%.

@@              Coverage Diff              @@
##             develop      #60      +/-   ##
=============================================
- Coverage      77.59%   76.37%   -1.22%     
- Complexity       373      414      +41     
=============================================
  Files             56       62       +6     
  Lines            839      961     +122     
  Branches          72       78       +6     
=============================================
+ Hits             651      734      +83     
- Misses           140      179      +39     
  Partials          48       48              

Impacted Files	Coverage Δ	Complexity Δ
...a/adapter/basic/ReadWriteAdapterVariableScope.java	100.00% <ø> (ø)	7.00 <0.00> (ø)
.../adapter/list/ListReadWriteAdapterCaseService.java	28.57% <28.57%> (ø)	1.00 <1.00> (?)
...ta/adapter/map/MapReadWriteAdapterCaseService.java	28.57% <28.57%> (ø)	1.00 <1.00> (?)
...ta/adapter/set/SetReadWriteAdapterCaseService.java	28.57% <28.57%> (ø)	1.00 <1.00> (?)
...camunda/bpm/data/factory/BasicVariableFactory.java	69.09% <31.81%> (+12.33%)	22.00 <3.00> (+5.00)
...nda/bpm/data/reader/CaseServiceVariableReader.java	50.00% <50.00%> (ø)	5.00 <5.00> (?)
...nda/bpm/data/writer/CaseServiceVariableWriter.java	75.00% <75.00%> (ø)	10.00 <10.00> (?)
...va/io/holunda/camunda/bpm/data/CamundaBpmData.java	100.00% <100.00%> (ø)	22.00 <2.00> (+2.00)
...ata/adapter/basic/ReadWriteAdapterCaseService.java	100.00% <100.00%> (ø)	7.00 <7.00> (?)
.../camunda/bpm/data/factory/ListVariableFactory.java	92.00% <100.00%> (+9.39%)	19.00 <2.00> (+3.00)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b336ba1...03d9751. Read the comment docs.

[jangalinski]

@zambrovski If I do not hear objections, I will merge and release tomorrow ... need this feature at work asap.

[zambrovski]

Wait for me Simon Zambrovski Dipl.-Ing.-Inf. Mobile: +49 176 1616 9010 E-Mail: simon@zambrovski.org Internet: http://simon.zambrovski.org/

…

Am 24.07.2020 um 15:37 schrieb Jan Galinski ***@***.***>:  @zambrovski If I do not hear objections, I will merge and release tomorrow ... need this feature at work asap. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[zambrovski]

Bad idea to combine change of formatting (actually why was is needed?) with functional features.

It looks ok to me, the continuous decrease of coverage is kind of weak, but it is not solely the problem of your change. Still, we started with above 80% and are below 60% now... more complexity and less tests seems to be a risky path.

I could not find any examples how to use it... I think there should be examples for usage and for mocking inside the official docs... three lines inside the release docs / features might be not enough to describe the feature you implemented.

[jangalinski]

Bad idea to combine change of formatting (actually why was is needed?) with functional features.

No idea why this wasn't formatted correctly in the first place ... should have been handled by the editorconfig

no examples ... cmmn is an edge case ... might add some later

[zambrovski]

Hm. The editor config says 2 spaces not 4. Are you sure you applied the correct formatter?

[jangalinski]

will check ... can you just fix it?

[zambrovski]

No. I have a cellphone only.

[jangalinski]

ah. :-)

ok ... will do

[jangalinski]

will do reformatting in separated pr ... to much clutter

[zambrovski]

Probably, a defined formatter is king! I asked you for one some time ago if you remember. For now I picked the default IDEA IntelliJ with Editor config...

…

Am 26.07.2020 um 11:08 schrieb Jan Galinski ***@***.***>:  will do reformatting in separated pr ... to much clutter — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[jangalinski]

I asked you for one some time ago if you remember

yes, i know. see #61 but combined formatting of java/kotlin and formatting that matches codacy are still unsolved issues.

I will merge this and do a follow-up push with correct formatting