Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#358): support List<Map<*,*>> variable factory #424

Conversation

mmiikkkkaa
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (d71245e) 77.74% compared to head (69fa316) 75.65%.

Files Patch % Lines
...tofmaps/ListOfMapsReadAdapterLockedExternalTask.kt 0.00% 16 Missing ⚠️
...istofmaps/ListOfMapsReadWriteAdapterCaseService.kt 20.00% 16 Missing ⚠️
...r/listofmaps/AbstractListOfMapsReadWriteAdapter.kt 47.82% 7 Missing and 5 partials ⚠️
...ofmaps/ListOfMapsReadWriteAdapterRuntimeService.kt 46.66% 8 Missing ⚠️
...istofmaps/ListOfMapsReadWriteAdapterTaskService.kt 64.28% 5 Missing ⚠️
...unda/bpm/data/factory/ListOfMapsVariableFactory.kt 89.28% 1 Missing and 2 partials ⚠️
...tofmaps/ListOfMapsReadWriteAdapterVariableScope.kt 84.61% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #424      +/-   ##
=============================================
- Coverage      77.74%   75.65%   -2.09%     
- Complexity       497      541      +44     
=============================================
  Files             76       84       +8     
  Lines           1339     1479     +140     
  Branches          83       90       +7     
=============================================
+ Hits            1041     1119      +78     
- Misses           245      300      +55     
- Partials          53       60       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmiikkkkaa mmiikkkkaa force-pushed the 358-support-listmapstring-any-variable-factory-since-it-is-a-common-result-of-a-dmn-evaluation branch 2 times, most recently from 031af43 to 8eb596d Compare January 19, 2024 14:39
@mmiikkkkaa mmiikkkkaa force-pushed the 358-support-listmapstring-any-variable-factory-since-it-is-a-common-result-of-a-dmn-evaluation branch from 8eb596d to 69fa316 Compare January 19, 2024 15:06
@mmiikkkkaa mmiikkkkaa requested a review from zambrovski January 25, 2024 22:18
@zambrovski zambrovski modified the milestone: 1.5.1 May 24, 2024
@zambrovski zambrovski added Type: enhancement New feature or request State: in progress Assignee is working on the issue. labels May 24, 2024
@zambrovski zambrovski merged commit dee4972 into develop May 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: in progress Assignee is working on the issue. Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support List<Map<String, Any>> variable factory, since it is a common result of a DMN evaluation
2 participants