Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ctrl-U behavior #876

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Fix Ctrl-U behavior #876

merged 3 commits into from
Jan 2, 2025

Conversation

kkebo
Copy link
Contributor

@kkebo kkebo commented Dec 28, 2024 •
edited
Loading

fixes #864

Changes:

  1. Fixed an issue where the cursor display position would be incorrect if PS1 contained invisible characters. (Cursor display position would go wrong after pressing Ctrl-U #864) 480284f
  2. Fixed that Ctrl-U unintentionally deletes characters behind the cursor. 01675da
  3. Added missing updatePromptPosition() after printPrompt(). 01675da
  4. Fixed Ctrl-U behavior when input crossing lines 7c0f0cb

@kkebo kkebo closed this Dec 28, 2024
@kkebo kkebo reopened this Dec 28, 2024
@kkebo kkebo marked this pull request as draft December 28, 2024 15:13
@kkebo kkebo changed the title Fix cursor display position after Ctrl-U Fix Ctrl-U behavior Dec 28, 2024
@kkebo kkebo marked this pull request as ready for review December 28, 2024 15:19
@kkebo kkebo mentioned this pull request Dec 28, 2024
Open
@holzschu
Copy link
Owner

holzschu commented Jan 2, 2025

Thanks for all these PR. I'm merging this one, then I'll make a TestFlight version.

@holzschu holzschu merged commit c2aa22c into holzschu:master Jan 2, 2025
@kkebo kkebo deleted the 864-fix-ctrl-u-cursor-position branch January 2, 2025 10:02
@kkebo
Copy link
Contributor Author

kkebo commented Jan 2, 2025

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor display position would go wrong after pressing Ctrl-U
2 participants
@kkebo @holzschu