Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty wrappers without items should not be visible in view mode #1026

Merged
merged 1 commit into from
Aug 25, 2024
Merged

fix: empty wrappers without items should not be visible in view mode #1026

merged 1 commit into from
Aug 25, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Aug 25, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

This will resolve the following issues from oldmarr:

Closes #1016

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Aug 25, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0-alpha.1 milestone Aug 25, 2024
@Meierschlumpf Meierschlumpf self-assigned this Aug 25, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner August 25, 2024 08:59
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Aug 25, 2024

Here's the code health analysis summary for commits ec2de90..967125c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.87% 11655 / 29229
🔵 Statements 39.87% 11655 / 29229
🔵 Functions 36.91% 282 / 764
🔵 Branches 71.36% 1079 / 1512
File CoverageNo changed files found.
Generated in workflow #2677

@SeDemal SeDemal merged commit 022fad9 into dev Aug 25, 2024
12 checks passed
@SeDemal SeDemal deleted the fix-empty-wrappers-visible branch August 25, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeDemal SeDemal SeDemal approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.

bug: empty section with no item should not be visible
2 participants
@Meierschlumpf @SeDemal