Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spotlight): add support for custom search-engines #1200

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Sep 28, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #289

image
image
image
image
image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Sep 28, 2024
@Meierschlumpf Meierschlumpf self-assigned this Sep 28, 2024
Copy link

deepsource-io bot commented Sep 28, 2024

Here's the code health analysis summary for commits 8aaa4f5..41740e5. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Sep 28, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.73% 14120 / 36456
🔵 Statements 38.73% 14120 / 36456
🔵 Functions 34.87% 363 / 1041
🔵 Branches 70.35% 1253 / 1781
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/layout.tsx 0% 0% 0% 0% 1-2, 24, 26-27, 29, 31-32, 34-150, 152-157, 159
apps/nextjs/src/app/[locale]/manage/apps/page.tsx 0% 0% 0% 0% 1-3, 6-8, 10-13, 15-17, 19-35, 37-38, 40, 46-47, 49-70, 72-75, 77-86, 88-94, 96, 98-99, 101-110, 112
apps/nextjs/src/app/[locale]/manage/search-engines/_form.tsx 0% 0% 0% 0% 1, 3-4, 6, 8, 10, 12, 24-26, 28-36, 38-60, 62-71, 73
apps/nextjs/src/app/[locale]/manage/search-engines/_search-engine-delete-button.tsx 0% 0% 0% 0% 1, 3-5, 8-12, 18-21, 23-48, 50-53, 55
apps/nextjs/src/app/[locale]/manage/search-engines/page.tsx 0% 0% 0% 0% 1-3, 6-9, 11-14, 16-20, 30-32, 34-35, 37-60, 63-67, 69, 75-76, 78-99, 101-113, 115-121, 123, 125-126, 128-137, 139
apps/nextjs/src/app/[locale]/manage/search-engines/edit/[id]/_search-engine-edit-form.tsx 0% 0% 0% 0% 1, 3-4, 7-9, 11, 14, 20-22, 24-40, 42-50, 52, 54-61, 63
apps/nextjs/src/app/[locale]/manage/search-engines/edit/[id]/page.tsx 0% 0% 0% 0% 1, 3-4, 6-8, 14-16, 18-25, 27
apps/nextjs/src/app/[locale]/manage/search-engines/new/_search-engine-new-form.tsx 0% 0% 0% 0% 1, 3-4, 6-8, 10, 13, 15-17, 19-34, 36-41, 43, 45-50, 52
apps/nextjs/src/app/[locale]/manage/search-engines/new/page.tsx 0% 0% 0% 0% 1, 3, 5-7, 9-10, 12-19, 21
packages/api/src/root.ts 0% 0% 0% 0% 1-16, 18-34
packages/api/src/router/app.ts 82.66% 100% 100% 82.66% 16-23, 28-32
packages/api/src/router/group.ts 90.15% 94.11% 100% 90.15% 87-92, 102-109, 172-176
packages/api/src/router/search-engine/search-engine-router.ts 0% 0% 0% 0% 1, 3-5, 7, 9-17, 19-23, 25-33, 35-40, 42-63, 65-70, 72-85
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/spotlight/src/components/spotlight.tsx 0% 0% 0% 0% 1, 3-6, 9, 12-15, 17-23, 25-27, 29-40, 42-45, 47-51, 53-66, 68-81, 83-84, 87-94, 96-100, 102-104, 106-113, 115-122, 124-125, 127
packages/spotlight/src/components/actions/group-actions.tsx 0% 0% 0% 0% 1-2, 5, 9-10, 19-24, 26-29, 31-34, 36-42, 44-45, 47-49, 51-61, 63-67, 69, 71-73, 75-77, 79-81, 83-93
packages/spotlight/src/components/actions/groups/action-group.tsx 0% 0% 0% 0% 1, 4-5, 9, 18-19, 21-22, 24-27
packages/spotlight/src/lib/group.ts 0% 100% 100% 0% 36
packages/spotlight/src/modes/external/search-engines-search-group.tsx 0% 0% 0% 0% 1-2, 5-6, 8-10, 14-19, 21-25, 27-42, 44-45, 47-61, 63-64, 66-68, 70-71, 73-85
packages/spotlight/src/modes/page/pages-search-group.tsx 0% 0% 0% 0% 1, 16, 18-19, 22-23, 25, 29-36, 38-44, 46-47, 49-51, 53-55, 57-61, 63-145, 147-159, 161-163
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/validation/src/app.ts 100% 100% 100% 100%
packages/validation/src/common.ts 100% 100% 100% 100%
packages/validation/src/group.ts 100% 100% 100% 100%
packages/validation/src/index.ts 100% 100% 100% 100%
packages/validation/src/search-engine.ts 100% 100% 100% 100%
packages/validation/src/form/i18n.ts 8.4% 50% 16.66% 8.4% 11-24, 27-31, 33-48, 50-56, 58-61, 64-68, 70-74, 76-83, 86-90, 92-99, 102-107, 109-130, 132-135
Generated in workflow #3108 for commit 41740e5 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf marked this pull request as ready for review September 28, 2024 16:30
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner September 28, 2024 16:30
SeDemal
SeDemal previously approved these changes Sep 30, 2024
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe check Mani's comment but lgtm

@Meierschlumpf Meierschlumpf merged commit 4c9471e into dev Oct 4, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the customize-search-engines branch October 4, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: improved search engines
3 participants