Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for multiple integration kind options #127

Merged
merged 2 commits into from
Feb 18, 2024
Merged

feat: add support for multiple integration kind options #127

merged 2 commits into from
Feb 18, 2024

Conversation

Meierschlumpf
Copy link
Member

image
image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Feb 17, 2024
@Meierschlumpf Meierschlumpf self-assigned this Feb 17, 2024
manuel-rw
manuel-rw approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can we remove the "Test connection" in a future PR and modify the "Create" / "Save" button to be "Test and create" and "Test and save" like in Grafana?

@Meierschlumpf
Copy link
Member Author

lgtm. Can we remove the "Test connection" in a future PR and modify the "Create" / "Save" button to be "Test and create" and "Test and save" like in Grafana?

Yes we can, thats a nice idea

@Meierschlumpf Meierschlumpf merged commit f1aa422 into dev Feb 18, 2024
6 checks passed
@Meierschlumpf Meierschlumpf deleted the add-support-for-multiple-integration-kind-options branch February 18, 2024 13:24
@Meierschlumpf Meierschlumpf mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw approved these changes

Assignees

@Meierschlumpf Meierschlumpf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meierschlumpf @manuel-rw