Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort & last seen #1363

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Oct 23, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy requested a review from a team as a code owner October 23, 2024 14:48
@hillaliy hillaliy self-assigned this Oct 23, 2024
@hillaliy hillaliy added the bug Something isn't working label Oct 23, 2024
Copy link

deepsource-io bot commented Oct 23, 2024

Here's the code health analysis summary for commits b542bad..1bf6eab. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.78% 14655 / 37784
🔵 Statements 38.78% 14655 / 37784
🔵 Functions 35.94% 381 / 1060
🔵 Branches 71.02% 1304 / 1836
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/api/src/router/widgets/health-monitoring.ts 0% 0% 0% 0% 1, 4, 6-7, 9-16, 18-26, 28-51
packages/widgets/src/health-monitoring/component.tsx 0% 0% 0% 0% 1, 19-20, 31-33, 35, 38, 41, 43, 45-59, 65-70, 72-87, 93-98, 100-114, 116-123, 125-134, 136-145, 147-152, 154-158, 160-164, 166-173, 175-181, 183-187, 189-210, 212-219, 221-231, 233-260, 262-266, 268-272, 275-278, 280-286, 288-289, 291-292, 294, 296-300, 302-303, 305-310, 325-329, 331-341, 343-344, 346-360, 362-369, 371, 373-388, 390-397, 399, 401-403, 405-418, 420-428, 430, 432-440, 442-447
Generated in workflow #3385 for commit 1bf6eab by the Vitest Coverage Report Action

Copy link
Member

@Meierschlumpf Meierschlumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the commit message more describtive, like adding the widget you changed and what is sorted

@hillaliy
Copy link
Contributor Author

The order of disks in the health monitoring widget changes every data refresh. To fix this I sorted the disk map so that the order of the disks would be fixed.
Also last seen show 55 years ago of, fixed too.

@hillaliy hillaliy merged commit f9bb696 into dev Oct 23, 2024
14 checks passed
@hillaliy hillaliy deleted the fix-health-monitoring-disks-sort-&-last-seen branch October 23, 2024 15:14
Meierschlumpf added a commit that referenced this pull request Oct 23, 2024
Co-authored-by: Yossi Hillali <hillaliy@me.com>
Meierschlumpf added a commit that referenced this pull request Oct 23, 2024
Co-authored-by: Yossi Hillali <950010+hillaliy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants