Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bookmarks options (apps) #2048

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat: add bookmarks options (apps) #2048

merged 5 commits into from
Jan 23, 2025

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Jan 21, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy added the enhancement New feature or request label Jan 21, 2025
@hillaliy hillaliy self-assigned this Jan 21, 2025
@hillaliy hillaliy requested a review from a team as a code owner January 21, 2025 15:03
@hillaliy hillaliy linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link

deepsource-io bot commented Jan 21, 2025

Here's the code health analysis summary for commits ce87d62..70c836d. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 2 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 21, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.3% 8433 / 39576
🔵 Statements 21.3% 8433 / 39576
🔵 Functions 25.32% 311 / 1228
🔵 Branches 62.23% 951 / 1528
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/old-import/src/widgets/options.ts 72.25% 100% 0% 72.25% 33-40, 62, 64, 67, 70, 135-137, 139-141, 144-146, 149, 165-187
packages/widgets/src/bookmarks/component.tsx 0% 0% 0% 0% 1-233
packages/widgets/src/bookmarks/index.tsx 50% 100% 0% 50% 27-45, 49-56
Generated in workflow #4735 for commit 70c836d by the Vitest Coverage Report Action

packages/translation/src/lang/en.json Outdated Show resolved Hide resolved
packages/translation/src/lang/en.json Outdated Show resolved Hide resolved
@hillaliy hillaliy merged commit 132db15 into dev Jan 23, 2025
13 checks passed
@hillaliy hillaliy deleted the bookmarks-options branch January 23, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: bookmarks options (apps)
2 participants