Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide current language switch in other users preferences #2069

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Jan 22, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2019

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Jan 22, 2025
@Meierschlumpf Meierschlumpf self-assigned this Jan 22, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner January 22, 2025 17:10
Copy link

deepsource-io bot commented Jan 22, 2025

Here's the code health analysis summary for commits 1f54bf5..6f268cb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Jan 22, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.27% 8403 / 39490
🔵 Statements 21.27% 8403 / 39490
🔵 Functions 25.49% 312 / 1224
🔵 Branches 62.27% 951 / 1527
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/page.tsx 0% 0% 0% 0% 1-130
Generated in workflow #4729 for commit 6f268cb by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit 470d27e into dev Jan 22, 2025
14 checks passed
@Meierschlumpf Meierschlumpf deleted the hide-current-language-switch branch January 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: changing user language for a different user in admin settings changes admin's language
1 participant