Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date & time widget padding cut off #2089

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Jan 23, 2025


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy added the bug Something isn't working label Jan 23, 2025
@hillaliy hillaliy self-assigned this Jan 23, 2025
@hillaliy hillaliy requested a review from a team as a code owner January 23, 2025 16:24
@hillaliy hillaliy linked an issue Jan 23, 2025 that may be closed by this pull request
Copy link

deepsource-io bot commented Jan 23, 2025

Here's the code health analysis summary for commits 7a6477a..cb3e60a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Meierschlumpf
Copy link
Member

Meierschlumpf commented Jan 23, 2025

@hillaliy can you add a screenshot?

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.31% 8427 / 39539
🔵 Statements 21.31% 8427 / 39539
🔵 Functions 25.38% 311 / 1225
🔵 Branches 62.23% 951 / 1528
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/widgets/src/clock/component.tsx 0% 0% 0% 0% 1-71
Generated in workflow #4745 for commit cb3e60a by the Vitest Coverage Report Action

@hillaliy
Copy link
Contributor Author

Screenshot 2025-01-23 at 18 35 02

@hillaliy hillaliy merged commit e4dd19b into dev Jan 23, 2025
17 checks passed
@hillaliy hillaliy deleted the date-time-widget-padding-cut-off branch January 23, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: Date and Time item has malformed padding
2 participants