Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add password requirements #988

Merged
merged 6 commits into from
Aug 19, 2024
Merged

feat: add password requirements #988

merged 6 commits into from
Aug 19, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented Aug 16, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label Aug 16, 2024
@Meierschlumpf Meierschlumpf self-assigned this Aug 16, 2024
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner August 16, 2024 13:43
Copy link

deepsource-io bot commented Aug 16, 2024

Here's the code health analysis summary for commits 0585187..8491772. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Aug 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 40.47% 11490 / 28387
🔵 Statements 40.47% 11490 / 28387
🔵 Functions 37.7% 282 / 748
🔵 Branches 71.68% 1076 / 1501
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/auth/invite/[id]/_registration-form.tsx 0% 0% 0% 0% 1, 3-4, 6-10, 12, 21-31, 33-52, 54-61, 63-73, 75-85, 87
apps/nextjs/src/app/[locale]/init/user/_init-user-form.tsx 0% 0% 0% 0% 1, 3-4, 6-10, 12, 14-24, 26-42, 44-50, 52-65, 67
apps/nextjs/src/app/[locale]/manage/users/[userId]/security/_components/_change-password-form.tsx 0% 0% 0% 0% 1, 3, 6-12, 14, 20-39, 41-45, 47-59, 61-65, 67-72, 75-80, 82-86, 88-96, 98
apps/nextjs/src/app/[locale]/manage/users/create/_components/create-user-stepper.tsx 0% 0% 0% 0% 1, 3-5, 7-13, 15, 17-19, 21-29, 31-40, 42-53, 55-71, 73, 75-77, 79-89, 91-96, 98-106, 108-116, 118-149, 151-180, 182
packages/api/src/router/test/user.spec.ts 100% 100% 100% 100%
packages/translation/src/lang/en.ts 100% 100% 100% 100%
packages/ui/src/components/index.tsx 100% 100% 100% 100%
packages/ui/src/components/password-input/password-input.tsx 28.57% 100% 0% 28.57% 15-17, 19-20, 23, 25-28, 30-33, 35
packages/ui/src/components/password-input/password-requirement.tsx 23.07% 100% 0% 23.07% 5-8, 10, 12-15, 17
packages/ui/src/components/password-input/password-requirements-popover.tsx 21.05% 100% 0% 21.05% 11-19, 22, 24-35, 37, 40, 42-43, 45-46, 48-49
packages/validation/src/index.ts 100% 100% 100% 100%
packages/validation/src/user.ts 100% 100% 100% 100%
Generated in workflow #2634

manuel-rw
manuel-rw previously approved these changes Aug 16, 2024
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very nice

manuel-rw
manuel-rw previously approved these changes Aug 18, 2024
@Meierschlumpf Meierschlumpf merged commit 2d155fa into dev Aug 19, 2024
10 checks passed
@Meierschlumpf Meierschlumpf deleted the password-requirements branch August 19, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants