Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
emontnemery committed Jan 16, 2024
1 parent 4db35a1 commit 9af098e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
flake8 --exclude cast_channel_pb2.py,authority_keys_pb2.py,logging_pb2.py examples pychromecast
- name: Lint with mypy
run: |
mypy pychromecast/const.py pychromecast/error.py pychromecast/models.py pychromecast/response_handler.py
mypy
- name: Lint with pylint
run: |
pylint examples pychromecast
8 changes: 1 addition & 7 deletions mypy.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[mypy]
python_version = 3.11
plugins = pydantic.mypy
show_error_codes = true
follow_imports = silent
local_partial_types = true
Expand All @@ -21,9 +20,4 @@ disallow_untyped_decorators = true
disallow_untyped_defs = true
warn_return_any = true
warn_unreachable = true

[pydantic-mypy]
init_forbid_extra = true
init_typed = true
warn_required_dynamic_aliases = true
warn_untyped_fields = true
files = pychromecast/const.py, pychromecast/error.py, pychromecast/models.py, pychromecast/response_handler.py
1 change: 0 additions & 1 deletion requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
black==23.12.1
flake8==7.0.0
mypy==1.8.0
pydantic==1.10.12
pylint==3.0.3

0 comments on commit 9af098e

Please sign in to comment.