Increase homeassistant lovelace connect timeout and make it configurable #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarthomefamilyverrips
approved these changes
Dec 1, 2023
|
@emontnemery can you look at this please. |
|
Just to clarify: you extended the timeout, but it is still not configurable from home assistant, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue where homeassistant dashboards would not always load correctly when casting. I also discovered I wasn't the only one experiencing this: home-assistant/core#82823. I tracked down the source of the warning message and did some testing and confirmed the exceptions were always thrown after 10 seconds exactly. Increasing the timeout allows the dashboard to show correctly and the error messages are gone.
10 seconds seems somewhat arbitrary here and some cast devices can be slow to load. Also since a bunch of people are having this issue I think it makes sense to increase the default timeout.
Another option would be to make this configurable in the cast integration to allow users experiencing this issue to set a larger timeout.