Add type annotations to socket_client.py #805
Conversation
emontnemery
force-pushed
the
type_annotations_socket_client
branch
from
8772557
to
624ec13
Compare
| else: | ||
| retry_log_fun( | ||
| "[%s(%s):%s] Failed to connect, retrying in %.1fs", | ||
| self.fn or "", | ||
| self.host, | ||
| self.port, | ||
| self.retry_wait, | ||
| ) |
There was a problem hiding this comment.
This should have been cleaned up as part of #556
pychromecast/socket_client.py
Outdated
| msg.namespace = namespace | ||
| msg.payload_utf8 = _json_to_payload(data) | ||
| msg.payload_utf8 = _json_to_payload(data) # type: ignore[assignment] |
There was a problem hiding this comment.
The code works, but violates the typing of CastMessage which says CastMessage.payload_utf8 should be a str.
Edit:
After some debugging of the pure Python version of protobuf, it turns our that the bytes provided by us is decoded to a str here: https://github.com/protocolbuffers/protobuf/blob/1d6ac5979b909a222db45cb154f0be3a31828324/python/google/protobuf/internal/type_checkers.py#L189, and then encoded again here: https://github.com/protocolbuffers/protobuf/blob/1d6ac5979b909a222db45cb154f0be3a31828324/python/google/protobuf/internal/encoder.py#L678
This is clearly a waste of CPU time, fixed in PR #806
|
There's a merge conflict. |
No description provided.