Reduce verbosity of reconnection #933
Conversation
elupus
commented
Jul 24, 2024
elupus
commented
- Reduce the verbosity of reconnection
- Make sure write errors log the original exception
- Reduce the verbosity of reconnection - Make sure write errors log the original exception
| @@ -649,16 +650,16 @@ def _check_connection(self) -> bool: | |||
| # check if connection is expired | |||
| reset = False | |||
| if self._force_recon: | |||
| self.logger.warning( | |||
| "[%s(%s):%s] Error communicating with socket, resetting connection", | |||
| self.logger.debug( | |||
There was a problem hiding this comment.
Debug is too low level, let's do info
There was a problem hiding this comment.
All places that set force_recon have already logged an error
There was a problem hiding this comment.
Also this log is rather useless, below low where it is increased would be more usefull.
ogger: pychromecast.socket_client
Källa: /usr/local/lib/python3.12/site-packages/pychromecast/socket_client.py:655
Inträffade först: 25 augusti 2024 kl. 02:00:06 (41 händelser)
Senast loggade: 19:26:34
[Announce Group(192.168.16.29):32096] Error communicating with socket, resetting connection
[Hela Huset(192.168.16.27):32053] Error communicating with socket, resetting connection
[Home Kök(192.168.16.29):8009] Error communicating with socket, resetting connection
[Cast Bibliotek(192.168.16.152):8009] Error communicating with socket, resetting connection
[65OLED855/12(192.168.16.36):8009] Error communicating with socket, resetting connection
pychromecast/socket_client.py
Outdated
| self.fn or "", | ||
| self.host, | ||
| self.port, | ||
| ) | ||
| reset = True | ||
|
|
||
| elif self.heartbeat_controller.is_expired(): | ||
| self.logger.warning( | ||
| self.logger.debug( |
There was a problem hiding this comment.
Missing heartbeat and reconnecting is not an issue we need to log (info could be okey). We only need to warn if we fail to reconnect.
There was a problem hiding this comment.
Also.. We will be getting these anyway if there is a real problem om reconnect:
Logger: pychromecast.socket_client
Källa: /usr/local/lib/python3.12/site-packages/pychromecast/socket_client.py:412
Inträffade först: 25 augusti 2024 kl. 02:00:35 (62 händelser)
Senast loggade: 19:26:34
[Home Kök(192.168.16.29):8009] Failed to connect to service HostServiceInfo(host='192.168.16.29', port=8009), retrying in 5.0s
[Nest Kontor(192.168.16.180):8009] Failed to connect to service HostServiceInfo(host='192.168.16.180', port=8009), retrying in 5.0s
[65OLED855/12(192.168.16.36):8009] Failed to connect to service HostServiceInfo(host='192.168.16.36', port=8009), retrying in 5.0s
[Cast Bibliotek(192.168.16.152):8009] Failed to connect to service HostServiceInfo(host='192.168.16.152', port=8009), retrying in 5.0s
[65OLED855/12(192.168.16.36):8009] Failed to connect to service MDNSServiceInfo(name='TPM191E-9d097cde37f733c13536e0f70255ccac._googlecast._tcp.local.'), retrying in 5.0s
| if callback_function: | ||
| callback_function(False, None) | ||
| if not no_add_request_id: | ||
| self._request_callbacks.pop(request_id, None) | ||
| self._force_recon = True | ||
| self.logger.info( | ||
| "[%s(%s):%s] Error writing to socket.", | ||
| self.logger.warning( |
There was a problem hiding this comment.
Why do we increase the severity here?
There was a problem hiding this comment.
This is a real error. It should not log secondarily due to force recon.
There was a problem hiding this comment.
Ps. This could also be some valid disconnection, which we likely should just info log. But if that is the case we can figure out that later.
|
@emontnemery ok like this? |
|
Hello, is this fixing System log:
{"event_type":"system_log_event","event":{"name":"pychromecast.socket_client","message":["[Living Room TV(192.168.1.155):8009] Failed to connect to service HostServiceInfo(host='192.168.1.155', port=8009), retrying in 5.0s"],"level":"ERROR","source":["/usr/local/lib/python3.12/site-packages/pychromecast/socket_client.py",412],"timestamp":1727949273.2699394,"exception":"","count":1,"first_occurred":1727949273.2699394},"origin":"LOCAL","time_fired":"2024-10-03T09:54:33.271117+00:00","context":{"id":"01J98WTY5QKK2N1A6AP8Z2K32Y","parent_id":null,"user_id":null}}
🖥 System log:
{"event_type":"system_log_event","event":{"name":"pychromecast.socket_client","message":["[Living Room TV(192.168.1.155):8009] Heartbeat timeout, resetting connection"],"level":"WARNING","source":["/usr/local/lib/python3.12/site-packages/pychromecast/socket_client.py",664],"timestamp":1727970838.3446555,"exception":"","count":1,"first_occurred":1727970838.3446555},"origin":"LOCAL","time_fired":"2024-10-03T15:53:58.345110+00:00","context":{"id":"01J99HD1T9A1EMZ2WCFN79MG3Z","parent_id":null,"user_id":null}}I am spammed with a lot of these messages. Everytime when i turn off my tv. And every 6h when tv is off as it is doing some short action by itself.. I would like to decrease level to debug for this reason (or other solution if possible). |
