Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APIRequestProtocol for APIfactory.request #510

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add APIRequestProtocol for APIfactory.request #510

merged 1 commit into from
Jun 23, 2022

Conversation

MartinHjelmare
Copy link
Contributor

@MartinHjelmare MartinHjelmare commented Jun 23, 2022 •
edited
Loading

  • A protocol is needed to allow users of the library to type the APIFactory.request method which is the main api function in use.

@ggravlingen
Copy link
Member

So essentially, the user would import the protocol and use it as a type hint in their application?

@MartinHjelmare
Copy link
Contributor Author

Yeah. I'm working on bumping the library in Home Assistant and this is one of the things that we need to address.

@ggravlingen
Copy link
Member

Great initiative!

@MartinHjelmare MartinHjelmare merged commit b61737b into master Jun 23, 2022
@MartinHjelmare MartinHjelmare deleted the add-api-request-protocol branch June 23, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggravlingen ggravlingen ggravlingen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinHjelmare @ggravlingen