Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add orjson support (#815)" #856

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Revert "Add orjson support (#815)" #856

merged 1 commit into from
Dec 27, 2023

Conversation

MartinHjelmare
Copy link
Contributor

  • This reverts commit 392543e.
  • We allowed orjson instead of regular json for serialization. But orjson returns bytes instead of string when serializing, which isn't compatible with the websocket connection.
  • Revert for now until we have time to fix it.

raman325
raman325 approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for picking this up

@MartinHjelmare
Copy link
Contributor Author

Verified working locally. 👍

@MartinHjelmare MartinHjelmare merged commit 1c375e7 into master Dec 27, 2023
3 of 4 checks passed
@MartinHjelmare MartinHjelmare deleted the revert-orjson branch December 27, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raman325 raman325 raman325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinHjelmare @raman325