Skip to content

Add helpers/stale-issues as an action #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

sairon
Copy link
Member

@sairon sairon commented Mar 4, 2024

There's currently a reusable workflow for marking issues as stale. This adds a reusable action, which allows for running the task along other helpers (e.g. most likely helpers/lock-issues) on the same runner and with a bit more flexibility than what can be achieved with the workflow. The inputs and steps stay the same as in the workflow.

@sairon sairon requested a review from agners March 4, 2024 11:21
sairon added 2 commits March 4, 2024 12:23
There's currently a reusable workflow for marking issues as stale.
This adds a reusable action, which allows for running the task along
other helpers (e.g. most likely helpers/lock-issues) on the same runner
and with a bit more flexibility than what can be achieved with the
workflow. The inputs and steps stay the same as in the workflow.
@sairon sairon force-pushed the add-stale-action branch from 59ebff1 to 9437593 Compare March 4, 2024 11:23
@sairon sairon changed the title Add helpers/stale-issue as an action Add helpers/stale-issues as an action Mar 4, 2024


runs:
using: "composite"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason we add this as a "composite" action instead of using the syntax for reusable workflows?
https://docs.github.com/en/actions/using-workflows/reusing-workflows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to use it in the same way as lock-issues (added in #104) and other helper actions - the stale job implemented as a workflow is an outlier and doesn't bring any extra benefits IMHO. So far the workflow is used only in in three repos so getting rid of that shouldn't be a big challenge now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also home-assistant/helper/stale-issues@master is a bit less clumsy than home-assistant/actions/.github/workflows/stale.yaml@master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #104 should have been a reusable flow as well (like stale.yaml), as that is not really a helper.
That one, and this PR is adding standalone actions, they are not really like the other helpers in this repository.

composite actions are designed to be a step in a job, for all these 3 they are meant to be the entire job.

@sairon sairon closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants