⬆️ upgrade deconz version to 2.29.1-beta as experimental #3931
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
📝 WalkthroughWalkthroughThe update introduces a new version entry and configuration adjustments for the deCONZ project. The version in the changelog, build.yaml, and config.yaml has been bumped to reflect release 7.1.0-beta (with deCONZ at 2.29.1-beta). Additionally, build.yaml and the Dockerfile have been enhanced by the introduction of a new argument, Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant BS as Build System
participant DF as Dockerfile
participant DS as Download Server
Dev->>BS: Trigger build with RELEASE_CHANNEL and DECONZ_VERSION
BS->>DF: Pass build arguments (RELEASE_CHANNEL, DECONZ_VERSION, BUILD_ARCH)
DF->>DS: Request deCONZ package using URL with RELEASE_CHANNEL
DS-->>DF: Return deCONZ package
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
deconz/build.yaml (1)
10-11: Verify impact on auto-updates for existing installations.The addition of
RELEASE_CHANNEL: betacould affect how existing installations handle auto-updates. We should ensure that:
- Stable installations don't automatically update to beta versions
- Users can explicitly opt-in to beta updates
Consider adding documentation to clarify:
- How the release channel affects auto-updates
- How users can opt-in/out of beta updates
- Potential risks of using beta versions
deconz/CHANGELOG.md (1)
3-5: Enhance changelog with more details about the beta release.The changelog entry should include:
- Notable changes or fixes in deCONZ 2.29.1-beta
- Any known limitations or issues in the beta version
- Instructions for users to report beta-related issues
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
deconz/CHANGELOG.md(1 hunks)deconz/Dockerfile(1 hunks)deconz/build.yaml(1 hunks)deconz/config.yaml(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- deconz/config.yaml
🧰 Additional context used
📓 Path-based instructions (6)
`*/**(html|markdown|md)`: - For instructional content in doc...
*/**(html|markdown|md): - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted.
- Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness.
- In step-by-step instructions, front the location phrase in the instructional sentence.
- In step-by-step instructions, front the 'goal' in the instructional sentence.
- In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence.
- do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner'
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
`*/**(html|markdown|md)`: - Use bold to mark UI strings. - I...
*/**(html|markdown|md): - Use bold to mark UI strings.
- If "" are used to mark UI strings, replace them by bold.
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
`*/**(html|markdown|md)`: - Be brief in your replies and don...
*/**(html|markdown|md): - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if"
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
`*/**(html|markdown|md)`: - Use sentence-style capitalizatio...
*/**(html|markdown|md): - Use sentence-style capitalization also in headings.
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
`*/**(html|markdown|md)`: do not comment on HTML used for ic...
*/**(html|markdown|md): do not comment on HTML used for icons
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
`*/**(html|markdown|md)`: Avoid flagging inline HTML for emb...
*/**(html|markdown|md): Avoid flagging inline HTML for embedding videos in future reviews for this repository.
deconz/CHANGELOG.mddeconz/build.yamldeconz/Dockerfile
🔇 Additional comments (2)
deconz/Dockerfile (2)
42-42: LGTM: Release channel argument added.The addition of
RELEASE_CHANNELargument aligns with the build configuration.
47-52: Verify beta channel URLs and consider adding fallback mechanism.The URLs have been updated to use the beta channel. Consider:
- Verifying that these URLs are accessible for beta releases
- Adding a fallback mechanism if beta channel URLs are unavailable
✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify that the beta channel URLs are accessible for each architecture # Test armhf URL echo "Testing armhf URL..." curl -I "http://deconz.dresden-elektronik.de/raspbian/beta/deconz-2.29.1-qt5.deb" # Test aarch64 URL echo "Testing aarch64 URL..." curl -I "http://deconz.dresden-elektronik.de/debian/beta/deconz_2.29.1-debian-buster-beta_arm64.deb" # Test default (amd64) URL echo "Testing amd64 URL..." curl -I "http://deconz.dresden-elektronik.de/ubuntu/beta/deconz-2.29.1-qt5.deb"Length of output: 2152
Beta Channel URLs Accessibility Verified
All beta channel URLs for armhf, aarch64, and amd64 returned an HTTP 200 OK response, confirming they are accessible. The suggestion to add a fallback mechanism remains an optional enhancement to handle potential future accessibility issues.
|
Hi there @pokulo 👋 Thanks for opening a pull request. Unfortunately, we cannot accept unstable versions. Once it has been released as stable, feel free to re-open the pull request and I'm happy to take a look. Thanks! 👍 ../Frenck |
I would be interested to get the most recent bug fixes of deconz by switching to this experimental 2.29.1-beta release. I am just curious, whether the deconz add-on can be upgraded to a beta release, while leaving auto-updating installs unaffected. My attempt do do that is to set the
stageback from defaultstabletoexperimental.If
stage: experimentalalso affects prior versions of the deconz add-on, than this likely means there is no support for auto-updates to stable releases only. In this case, I guess it is just to early to upgrade all users to a beta version and I am totally ok with simply closing this PR.Summary by CodeRabbit