Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Material Design Icons to 7.0.96 #2709

Closed
jpelgrom opened this issue Jul 24, 2022 · 7 comments · Fixed by #3631
Closed

Update Material Design Icons to 7.0.96 #2709

jpelgrom opened this issue Jul 24, 2022 · 7 comments · Fixed by #3631
Labels
enhancement New feature or request

Comments

@jpelgrom
Copy link
Member

Is your feature request related to a problem? Please describe.

On Discord there was a message about Material Design Icons 7.0.96, which will be included in the next frontend release and includes breaking changes. The app should be updated to the latest version to handle these changes and provide a good experience.

Describe the solution you'd like

Update the Material Design Icons included in the app to version 7.0.96 or newer.

One icon used by the app should be renamed to mdi:microphone-message:

AudioManager.MODE_CALL_SCREENING -> "mdi:text-to-speech"

MDI icons are used and provided by two libraries:

  1. Android-Iconics, currently on 6.4.95 and no update available. Main + Wear app.
    It shouldn't be too hard to create a PR here and update it, @leroyboerefijn suggested he might do it.

  2. Icon Picker Dialog, currently on 5.3.45 and no update available - library hasn't been updated in ~2 years. Main app only.
    Updating it is difficult because it depends on this file which also is out of date, and there doesn't appear to be any activity. @goyney, a MDI contributor, offered to look into it and said:

Okay, so we have no connection to either of those libraries, so unfortunately, I have no pull to get them updated. I can tell you though, that they should have never been using that PeterShaggyNoble link. His work wasn't anything official and he had personal things come up that has severely limit his time to help out now or in the future.

My suggestion would be to either fork or create a new library and use the official libraries we provide, specifically @mdi/svg. It contains meta.json that will always be up-to-date with out latest releases: https://github.com/Templarian/MaterialDesign-SVG/blob/master/meta.json

It can be installed and version controlled via NPM.

Describe alternatives you've considered, if any

No realistic alternatives

Additional context

Including two libraries with these icons also feels redundant, perhaps a better solution would be to start bundling the icons ourselves and create a simple wrapper and icon picker like the frontend?

@jpelgrom jpelgrom added the enhancement New feature or request label Jul 24, 2022
@mririgoyen
Copy link

I'm not an Android dev and my free time is a little limited at the moment due to family, but please let me know if I can be of any assistance on the MDI side of things.

@jpelgrom
Copy link
Member Author

@NotWoods I noticed that you had done some work on a Compose-based icon dialog for the Android-Iconics icons on a branch in your repository - was that related to this issue by any chance? At first glance it's a nice start.

@NotWoods
Copy link
Contributor

It's for this issue, I just didn't have it working yet and got pulled to other projects. I'll take another stab for hacktoberfest :)

@jpelgrom
Copy link
Member Author

jpelgrom commented Sep 30, 2022

It looks like my PR to update MDI for Android-Iconics was merged a few hours ago, so library 1 from the issue description should be updated soon -> #2944

@NotWoods
Copy link
Contributor

Currently I'm running into backwards-compat issues. The dialog works but its not clear how to convert between the IDs each library uses. MDI uses unicode codepoints but Iconics uses some arbitrary hex values.

@jpelgrom
Copy link
Member Author

If I understand it correctly, the reason characters are remapped in Iconics to a different range is because of compatibility issues on some devices. It does use the same icon names as the official MDI which you're supposed to use (see: all places in the app where Iconics is currently used).

However, the existing Icon Picker Dialog doesn't include any information about codepoints at all I think and is using even more arbitrary IDs? It seems inevitable to include a (generated) file that simply maps one ID to another.

@NotWoods
Copy link
Contributor

NotWoods commented Oct 16, 2022

The existing dialog does at least have a file in its source code with a mapping. I'll look at using the names, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants