Jetpack Compose icon dialog #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix and update database migration - Fix dependencies - Fix shortcut icons - Fix ComposeView in AlertDialog not working by switching implementation to DialogFragment - Fix icons that no longer exist - ktlint
- Automotive asset - Handle icon ids in shortcuts to prevent users losing icons when updating shortcuts - Add padding, color filter to shortcut icons to keep icons consistent with older icons - Increase button widget icon padding to keep sizing consistent - Add tip to dialog about searching in non-English languages
JBassett
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes @NotWoods' Compose icon dialog PR #3016 (thanks for all the work!) and rebases + updates it to work with a recent version of the app and fix various issues with the original code.
Migration extensively tested and should be pretty smooth - the icons now have less padding included than the previous icon dialog library so I've adjusted sizes in a few places to compensate for this.
The number of lines changed looks intimidating but it's not too bad as it includes a database JSON file and indentation changes.
Fixes #2709
Closes #3016
Screenshots
Link to pull request in Documentation repository
n/a
Any other notes