Skip to content

Apply various IDE code quality suggestions #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jpelgrom
Copy link
Member

Summary

Improve code quality by applying various suggestions from Android Studio, most of which included 'quick fixes'. No changes in app functionality. This includes things like:

  • simplifying comparisons
  • removing unused code unlikely to be used in the future
  • more idiomatic Kotlin usage
  • using val instead of var where possible
  • unused imports

Combined with previous PRs cleaning up deprecations, this closes #3196

Screenshots

n/a

Link to pull request in Documentation repository

n/a

Any other notes

Verified

This commit was signed with the committer’s verified signature.
jpelgrom Joris Pelgröm
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up :)

@JBassett JBassett merged commit 670b17e into home-assistant:master Jul 31, 2023
@jpelgrom jpelgrom deleted the studio-code-quality-suggestions branch July 31, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants