-
-
Notifications
You must be signed in to change notification settings - Fork 788
Add support for alarm control panels in android auto #3765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/src/main/java/io/homeassistant/companion/android/util/vehicle/DomainChecks.kt
Outdated
Show resolved
Hide resolved
Looking at the card example, it suggests that it is possible for an alarm to only support |
the docs around configuring the domain do not show you can turn off the other alarm types. https://www.home-assistant.io/integrations/manual |
I see what you mean there is indeed supported feature support here, so will add a check to make sure the entity properly supports the action. |
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Outdated
Show resolved
Hide resolved
One more thing: the |
done :) |
common/src/main/java/io/homeassistant/companion/android/common/data/integration/Entity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but I'm not able to test this live
for testing I had 2 panels up. 1 with a code and the other without a code. I could only test using the Manual alarm control panel |
Summary
Fixes: #3710
We will show Alarm Control Panels as a supported domain because they are important enough IMO.
Only if we detect a code is not required will a user be able to click on it, otherwise it will be non-actionable.
Given the use case we will either
disarm
orarm_away
the alarm, the other arming options don't feel as if they would be used as much asarmed_away
Used the same icons from the frontend: https://github.com/home-assistant/frontend/blob/858dd738684b604b7861ccb9e2c449f9280f8723/src/common/entity/alarm_panel_icon.ts#L15-L36
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#968
Any other notes
After going on the first road trip this weekend the question of "did we turn on the alarm" came while in the car and it would've been easy to answer that 😂