Update strings for sentence-style casing #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
approved these changes
Aug 7, 2023
dshokouhi
reviewed
Aug 7, 2023
JBassett
approved these changes
Aug 7, 2023
…sing # Conflicts: # common/src/main/res/values/strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update all strings in strings.xml to use sentence-style casing to be consistent and align with Home Assistant core, the frontend (the latest commit to the strings there as of now did the same) and Android/Material guidelines + remove a few unnecessary periods. Noticed this (again) while reviewing the vehicle alarm panel PR.
Tested: this does not change names for previously registered sensors.
Screenshots
Probably every screen changed, not going to make screenshots.
Link to pull request in Documentation repository
n/a
Any other notes