Don't force on/yes/y/off/no/n to booleans for service button #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Relax string conversion to boolean as this breaks other use cases.
dshokouhi
approved these changes
Sep 11, 2023
JBassett
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3715 by relaxing string conversion to boolean as this breaks other use cases. The app isn't a full YAML parser, and doesn't need to be as the user can enter true/false in the same text field.
This will not be a breaking change as existing widgets have already had their
on/yes/y/off/no/nstrings* converted totrue/false, which will continue to work.*Depending on the YAML version these weren't a valid boolean anyway so confusion everywhere.
Screenshots
n/a
Link to pull request in Documentation repository
I couldn't find documentation about Home Assistant's YAML version or parsing anywhere so I think it's OK not to mention this anywhere.
Any other notes