Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon #3888

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Update icon #3888

merged 3 commits into from
Sep 28, 2023

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Sep 23, 2023

Summary

  • Replace old icon with the new icon
  • Deduplicate icon resources

Screenshots

Everywhere the Home Assistant icon was, or the primary color was used, it should now be changed. For example in the launcher, old vs new:
Old Home Assistant icon on the left, new Home Assistant icon on the right

And as a notification icon:
Status bar with various notification icons, including one from Home Assistant

Link to pull request in Documentation repository

n/a

Any other notes

@jpelgrom
Copy link
Member Author

Changing to draft to receive clarification on what the frontend will do re. primary color

@jpelgrom jpelgrom marked this pull request as draft September 23, 2023 17:35
@LasseRosenow
Copy link
Contributor

I think now that we have a new logo, maybe we should discuss the "centering in a circle" problem.

On the old icon it was much more obvious, but still the new icon still suffers this problem I think.
Even though it is technically centered, it does not look quite centered.

There is a very good post on medium about this:
https://medium.com/@erqiudao/the-play-button-is-not-optical-alignment-4cea11bda175

So in general we should try to center the center of the house by drawing a circle around it and using the circles center point as the center and not by drawing a rectangle and centering this :)

How do you think about this?

@LasseRosenow
Copy link
Contributor

LasseRosenow commented Sep 25, 2023

I created an example of how the icon would look using a circle to center it:

Centered using a square (Current) Centered using a circle (Proposed)
launcher_new_broken launcher_new_fixed
launcher_new_broken_red_border launcher_new_fixed_red_border

My honest thoughts are that while the one that is centered using a square looks like it is too much down, the one using a circle looks like it is a little bit to high up. Maybe we should put the icon somewhere in between 🤔 ... maybe using the Golden Ratio?

 - Replace old icon with the new icon
 - Update app primary color to new blue tint
 - Deduplicate resources
@jpelgrom
Copy link
Member Author

Thanks. Turns out they did create a circle-specific design I wasn't aware of.

@dshokouhi
Copy link
Member

Should we also update our play store listing icon with this PR?

@jpelgrom
Copy link
Member Author

It is also updating the listing icon, isn't it?

@dshokouhi
Copy link
Member

yes it is, shouldve searched before commenting 🤦

@jpelgrom
Copy link
Member Author

Frontend isn't changing primary color, decoupled.

@jpelgrom jpelgrom marked this pull request as ready for review September 28, 2023 19:42
@Madelena
Copy link

Looking good 👍

@JBassett JBassett merged commit 4a4cc31 into home-assistant:master Sep 28, 2023
3 checks passed
@jpelgrom jpelgrom deleted the new-icon branch September 28, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants