Update tiles logged out state to prevent cut off overflow, shortcuts tile label #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Limit length of logged out state string to prevent text cut off and shorten strings to help with translations - Fix inconsistent shortcuts tile name
dshokouhi
approved these changes
Oct 26, 2023
JBassett
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was another review failure about text sizes on Wear, and after playing with some string lengths I found it was possible to have text cut off on the logged out state for tiles (but only after making strings longer - maybe Google has an extremely small test device?). This PR limits length of logged out state string to the recommendation to prevent text cut off, and shortens strings to help with translations.
(Also a minor related fix for inconsistent shortcuts tile name usage.)
Screenshots
Link to pull request in Documentation repository
n/a
Any other notes