Show server name in "Unable to connect to Home Assistant" dialog #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Shows the server name instead of a generic "Home Assistant" to prevent confusion when the app cannot connect in the WebViewActivity, when using multiserver.
dshokouhi
approved these changes
Nov 3, 2023
JBassett
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By suggestion: show the server name instead of a generic "Home Assistant" to prevent confusion when the app cannot connect in the
WebViewActivity, when using multiserver.Adding a button to switch servers here would probably also be a nice improvement, but that doesn't fit and this dialog currently is used for a lot of things so let's not try to do everything in one PR. (Switching now requires going to Settings or dismissing the dialog and using swipe gestures.)
Screenshots
Server name: Home
Link to pull request in Documentation repository
n/a
Any other notes