Support showing all frames of animated gif image in Android 14+ #4284
Conversation
|
I think we will need a minor docs change for this as we currently mention GIFs are not animated :) https://companion.home-assistant.io/docs/notifications/notification-attachments
yup we have 2 on the same page 😅 |
|
Yeah I was wondering about that, sounds good I will create that and link it up |
app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/io/homeassistant/companion/android/notifications/MessagingManager.kt
Outdated
Show resolved
Hide resolved
|
@jpelgrom I see what you mean, what is your suggestion to handle this? We could extend the cutoff to 24 hours assuming no notifications will be kept that long |
|
Extending the cutoff to 24-48 hours seems acceptable enough to me while still keeping storage use to a minimum. |
|
@dshokouhi just curious, is there a way to access the apks that are automatically generated or just need to wait for weekly release on github? |
any action taht pushes to master will contain the latest APK now like https://github.com/home-assistant/android/actions/runs/8402417849 in the artifact |
|
awesome, thank you! |
Summary
This adds support for saving a gif that is sent as a notification image locally so that it can be loaded using a content uri which enables the notification to show the gif as animated including all frames.
Should be noted that this only is only supported on Android 14+, for previous versions the behavior and handling will remain the same where only the first frame of the gif is shown.
Screenshots
demo.mov
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1047
Any other notes
closes #1270