Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "No unique cases found to override" log (not specific enough) #4439

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

Roffild
Copy link
Contributor

@Roffild Roffild commented Jun 5, 2024

bug

Problem-Error:

'if' must have both main and 'else' branches if used as an expression :467

@dshokouhi
Copy link
Member

please share the YAML you used to reproduce the flooded log message as i do not see that flooded message at all on my end

@Roffild
Copy link
Contributor Author

Roffild commented Jun 5, 2024

#4358 (comment)

Server off-line.

please share the YAML you used

YAML from the server?

@dshokouhi
Copy link
Member

#4358 (comment)

Server off-line.

is this repeated log message caused by using the code in that PR? Because the method will not continuously load as the page does not refresh repeatedly.

please share the YAML you used

YAML from the server?

the method in question gets called when a user clicks on a link in their dashboard, we have specific code in place to intercept links and if you are seeing those repeated log messages then you either have some erroneous dashboard setup or submitting a PR against code changes that are not in the code base.

While I agree the log line is not informative here its important to understand how your seeing repeated messages as us devs do not see that.

@Roffild
Copy link
Contributor Author

Roffild commented Jun 7, 2024

Screenshot from testing #4412 But this bug is not related to this PR.

This is a WebView feature:
After the first HA load, a script for reconnection gets into the cache.
This script requests the URL.
WebView filters the URL in shouldOverrideUrlLoading.

WebViewClient.shouldOverrideUrlLoading()

If a WebViewClient is provided, returning true causes the current WebView to abort loading the URL, while returning false causes the WebView to continue loading the URL as usual.

bug

@jpelgrom
Copy link
Member

jpelgrom commented Jun 12, 2024

The fact that you're seeing the countdown go negative and refresh every second shouldn't happen. If you can reliably reproduce this, please file a frontend bug.

Editing PR title to better reflect the change.

Edit: forgot to press approve but consider the merge an approval.

@jpelgrom jpelgrom changed the title Deleting the log message with a non-stop flood Remove "No unique cases found to override" log (not specific enough) Jun 12, 2024
@jpelgrom jpelgrom merged commit cdaf17f into home-assistant:master Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants